feat(js-lib): Add sourceMaps.inject() for injecting debug IDs#3088
feat(js-lib): Add sourceMaps.inject() for injecting debug IDs#3088
sourceMaps.inject() for injecting debug IDs#3088Conversation
This comment was marked as resolved.
This comment was marked as resolved.
lib/releases/index.ts
Outdated
| * @param options Options to configure the source map upload. | ||
| * @returns A promise that resolves when the upload has completed successfully. | ||
| */ | ||
| // TODO: Move `uploadSourceMaps()` from Releases to SourceMaps class as `.upload()` |
There was a problem hiding this comment.
SGTM, but I think we can leave this command in place to avoid breaking anyone once we move things over.
There was a problem hiding this comment.
I changed the comment a bit so we know of this in the future
| * @param options Options to configure the source map upload. | ||
| * @returns A promise that resolves when the upload has completed successfully. | ||
| */ | ||
| // TODO: Add `uploadSourceMaps()` to SourceMaps class as `.upload()` (keep it here too for backward compatibility) |
There was a problem hiding this comment.
@s1gr1d did you mean to address this TODO in the current changes?
There was a problem hiding this comment.
No, that would be another PR. It's an unrelated change
There was a problem hiding this comment.
m: Got it, is there an issue for this already? If not, can you please make one? 🙏
l: I would suggest we delete the // TODO comment as the issue should suffice.
| // TODO: Add `uploadSourceMaps()` to SourceMaps class as `.upload()` (keep it here too for backward compatibility) |
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good, please see most recent comment prior to merge
| * @param options Options to configure the source map upload. | ||
| * @returns A promise that resolves when the upload has completed successfully. | ||
| */ | ||
| // TODO: Add `uploadSourceMaps()` to SourceMaps class as `.upload()` (keep it here too for backward compatibility) |
There was a problem hiding this comment.
m: Got it, is there an issue for this already? If not, can you please make one? 🙏
l: I would suggest we delete the // TODO comment as the issue should suffice.
| // TODO: Add `uploadSourceMaps()` to SourceMaps class as `.upload()` (keep it here too for backward compatibility) |
4 participants
Description
The JS Bundler Plugins repo uses the CLI instance in the Build Plugin Manager. However, injecting debug IDs is handled with a "raw"
.execute(). This PR adds this directly to the CLI instance under the namespacesourceMaps. Uploading source maps can be handled through this namespace as well in the future.related PR: getsentry/sentry-javascript-bundler-plugins#836